Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/audio size filter #184

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Feature/audio size filter #184

merged 4 commits into from
Jan 19, 2024

Conversation

drcege
Copy link
Collaborator

@drcege drcege commented Jan 18, 2024

  • Add new OP audio_size_filter
  • rename get_image_size to get_file_size

@drcege drcege self-assigned this Jan 18, 2024
@drcege drcege added enhancement New feature or request dj:multimodal issues/PRs about multimodal data processing dj:op issues/PRs about some specific OPs labels Jan 18, 2024
@drcege drcege added this to the Multimodal Support milestone Jan 18, 2024
@drcege drcege linked an issue Jan 18, 2024 that may be closed by this pull request
[MM] audio size filter #185
Closed
HYLcool
HYLcool approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@HYLcool HYLcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drcege drcege merged commit 33d82fe into main Jan 19, 2024
5 checks passed
@HYLcool HYLcool deleted the feature/audio_size_filter branch January 19, 2024 02:26
@HYLcool HYLcool linked an issue Jan 19, 2024 that may be closed by this pull request
[MM] support audio data basic processing OPs #97
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HYLcool HYLcool HYLcool approved these changes

@chenhesen chenhesen Awaiting requested review from chenhesen

@BeachWang BeachWang Awaiting requested review from BeachWang

@zhijianma zhijianma Awaiting requested review from zhijianma

@yxdyc yxdyc Awaiting requested review from yxdyc

Assignees

@drcege drcege

Labels
dj:multimodal issues/PRs about multimodal data processing dj:op issues/PRs about some specific OPs enhancement New feature or request
Projects
None yet
Milestone
DJ-SORA
Development

Successfully merging this pull request may close these issues.

[MM] audio size filter [MM] support audio data basic processing OPs
3 participants
@drcege @HYLcool @yxdyc