Fix bug in reset timeout on progress #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliffhall
approved these changes
Apr 2, 2025
|
Thanks for this awesome job, guys! @cliffhall, I have a question: When do you expect to release this bug issue? I'm willing to use it asap. Thank you once again! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a bug where resetTimeoutOnProgress option was being ignored - timeouts were being reset on every progress notification regardless of the setting. All requests with progress notifications got their timeouts reset, even when resetTimeoutOnProgress: false
How Has This Been Tested?
Added a specific test case that verifies requests don't reset their timeout when resetTimeoutOnProgress: false is set. This test failed before the fix and now passes.
Breaking Changes
None
Types of changes