Relax pydantic, pydantic-settings, and uvicorn requirements #180
Conversation
jeremydanielfox
force-pushed
the
jeremy/relax-pydantic
branch
2 times, most recently
from
2a61357 to
a1cd895
Compare
jeremydanielfox
force-pushed
the
jeremy/relax-pydantic
branch
from
a1cd895 to
0d48a44
Compare
jeremydanielfox
changed the title
| # Normalize the my_model_a_with_default field to handle both pydantic formats | ||
| if 'allOf' in actual_schema['properties']['my_model_a_with_default']: | ||
| normalized_schema['properties']['my_model_a_with_default'] = { | ||
| '$ref': '#/$defs/SomeInputModelA', |
There was a problem hiding this comment.
Seems odd to me that you've relaxed down to 2.7.2, but in order to get this test passing you cast it to the "Pre-pydantic 2.7.2" version.
I suspect either your comment is wrong, or I'm misunderstanding something
There was a problem hiding this comment.
Sorry, the comment was wrong. I researched exactly when this change was made and updated the comment to reflect it.
The change happened in Pydantic 2.9.0. Here are the release notes for that change. You can see the PR here that made the change.
There was a problem hiding this comment.
To confirm that this works, I ran the test with pydantic 2.7.2 (the new version we are relaxing to) and 2.10.1 (the previously required lower bound) and confirmed the test passes with both.
Motivation and Context
This PR relaxes version constraints for several dependencies to improve compatibility, without changing functionality.
pydantic: Changed from>=2.10.1,<3.0.0to>=2.7.2,<3.0.0pydantic-settings: Changed from>=2.6.1to>=2.5.2uvicorn: Changed from>=0.30to>=0.23.1In addition to changing the version requirements, the main change in this PR is to fix a test that previously had been failing at pydantic 2.7.2, which had prompted @dsp-ant to upgrade the pydantic version. The relevant difference pre and post 2.7.2 pydantic was just in the JSON schema representation format. This fix was to make the test handle both pre-2.7.2 and post-2.7.2 pydantic JSON schema formats. Both schemas mean the same thing.
How Has This Been Tested?
I tested this by running the test suite with both pydantic 2.7.2, and 2.10.1, to confirm the tests passed for both. For uvicorn and pydantic-settings, I examined the change log and the usage of these libraries in the code to make sure there were no breaking changes.
Breaking Changes
There are no breaking changes here.
Types of changes
Relaxes dependency requirements, fixes a test that failed at an earlier dependency.
Checklist
Additional context