async and await for send_log_message in fastmcp #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2025
|
Sorry I had to revert this. It caused tests to fail. feel free to reopen with fixed tests. |
|
Will investigate and try to fix tests. |
|
actually i found the error, i fixed it. |
|
Did these changes not make it into the 1.2.1 version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
context.send_log_message is async, callers of this method in fastmcp need to be async as well
How Has This Been Tested?
Yes, with Inspector. With the change, error messages about send_log_message "not awaited" have gone away. I do not, however, see the log messages in the Inspector notification pane.
Breaking Changes
Yes, users of Context.info(), etc will need to await.
Types of changes
Checklist
Additional context