Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract request and notification handling #166

Merged
merged 1 commit into from
Jan 24, 2025
Merged

refactor: extract request and notification handling #166

merged 1 commit into from
Jan 24, 2025

Conversation

dsp-ant
Copy link
Member

@dsp-ant dsp-ant commented Jan 23, 2025

Summary

  • Extract request and notification handling into separate methods
  • Improve code organization and readability
  • Prepare for request cancellation support

Test plan

  • Run all tests
  • Verify request handling still works
  • Test notification handling

Depends on #165

@dsp-ant dsp-ant mentioned this pull request Jan 23, 2025
Merged
3 tasks
jerome3o-anthropic
jerome3o-anthropic previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jerome3o-anthropic jerome3o-anthropic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dsp-ant dsp-ant force-pushed the davidsp/types-2024-11-05 branch from 50e60d7 to bd74227 Compare January 24, 2025 09:53
Base automatically changed from davidsp/types-2024-11-05 to main January 24, 2025 09:53
@dsp-ant dsp-ant dismissed jerome3o-anthropic’s stale review January 24, 2025 09:53

The base branch was changed.

@dsp-ant dsp-ant merged commit 5f537a0 into main Jan 24, 2025
3 checks passed
@dsp-ant dsp-ant deleted the davidsp/refactor branch January 24, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome3o-anthropic jerome3o-anthropic jerome3o-anthropic left review comments

@jspahrsummers jspahrsummers Awaiting requested review from jspahrsummers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsp-ant @jerome3o-anthropic