Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fastmcp debug logging #158

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

micpst
Copy link
Contributor

@micpst micpst commented Jan 18, 2025

Fixes server crash when setting up the debug logging.

Motivation and Context

FastMCP crashes when I set log level to DEBUG. Turns out there's a spot in the code where it overwrites the LoggerRecord name attribute, which happens to be a reserved keyword - https://docs.python.org/3/library/logging.html#logrecord-attributes.

How Has This Been Tested?

Tried running the MCP server with the log level set to DEBUG.

app = FastMCP("Demo", log_level="DEBUG")

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@dsp-ant dsp-ant self-requested a review January 20, 2025 11:51
@dsp-ant dsp-ant changed the base branch from main to v1.2.x January 20, 2025 11:54
@dsp-ant dsp-ant changed the base branch from v1.2.x to main January 20, 2025 11:54
@dsp-ant dsp-ant merged commit 73c62c5 into modelcontextprotocol:main Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants