Fix: Pre-registered Client ID as fallback to DCR #684
+16
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The guided auth flow did not support static client fallback after dynamic client registration (DCR) had failed. This doesn't meet the MCP spec.
The MCP spec authorization states:
This PR adds a static client credentials attempt as a fallback for failed DCR. If DCR is supported and successful, the static client will not be used.
Addresses #683.
How Has This Been Tested?
Tested locally with MCP servers with both DCR and static fallback.
Breaking Changes
No, purely an additive fallback.
Types of changes
Additional context
Potentially static client should take precedence if provided. That's the behaviour i'd personally expect, but that's opinionated. Either way, changes are expected to DCR as MCP spec roadmap already states looking for DCR alternatives
LMK if any changes needed, happy to change this around if another approach works better with the codebase, haven't worked with MCP inspector before.