Allow setting the timeout with the "timeout" URL parameter #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failing - think it is related to this commit in the SDK: modelcontextprotocol/typescript-sdk@e911ece Will fix. |
|
@evalstate I have a PR open to update the SDK #101 |
|
OK. I've added a commit - I'll wait for your PR to go through and merge. Best. |
|
Sorry about the breakage here! Per discussion on #101, didn't mean to release this breaking change—working on fixing it up now 😟 |
|
@evalstate I've updated the SDK to 1.0.3, mind rebasing this PR (and removing the second commit)? |
evalstate
force-pushed
the
fix/tool-timeout
branch
from
2384f75 to
e7d68a0
Compare
evalstate
force-pushed
the
fix/tool-timeout
branch
from
57c36ab to
bd6a636
Compare
|
Rebased; commits tidied. |
ashwin-ant
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting the Request Timeout in milliseconds with a "timeout" URL parameter
Motivation and Context
Enables testing of tools which take > 10s to respond.
How Has This Been Tested?
This has been tested using the mcp-everything server
Breaking Changes
No breaking changes.
Types of changes
Checklist
Additional context
@ashwin-ant this is intended to cover simple cases - I considered matching progress updates to requestids to reset the timer - but that seems over-engineered for the need.