Skip to content

Commit

Permalink
miri: disable test_downgrade_observe test on macOS
Browse files Browse the repository at this point in the history
  • Loading branch information
RalfJung authored and gitbot committed Feb 20, 2025
1 parent 5403e91 commit f94853d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion std/src/sync/rwlock/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -511,12 +511,15 @@ fn test_downgrade_basic() {
}

#[test]
// FIXME: On macOS we use a provenance-incorrect implementation and Miri catches that issue.
// See <https://github.com/rust-lang/rust/issues/121950> for details.
#[cfg_attr(all(miri, target_os = "macos"), ignore)]
fn test_downgrade_observe() {
// Taken from the test `test_rwlock_downgrade` from:
// https://github.com/Amanieu/parking_lot/blob/master/src/rwlock.rs

const W: usize = 20;
const N: usize = 100;
const N: usize = if cfg!(miri) { 40 } else { 100 };

// This test spawns `W` writer threads, where each will increment a counter `N` times, ensuring
// that the value they wrote has not changed after downgrading.
Expand Down

0 comments on commit f94853d

Please sign in to comment.