Skip to content

Commit

Permalink
Remove l4re from the unsigned char operating system list
Browse files Browse the repository at this point in the history
As noted in rust-lang#132975 (comment),
the default for userland apps is to follow the architecture defaults, the
-funsigned-char flag only applies to kernel builds.
  • Loading branch information
arichardson authored and gitbot committed Feb 20, 2025
1 parent 978bb9e commit cd34d19
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/src/ffi/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ mod c_char_definition {
// in clang/lib/Driver/ToolChains/Clang.cpp):
// - PowerPC uses unsigned char for all targets except Darwin
// - Arm/AArch64 uses unsigned char except for Darwin and Windows
// - L4RE builds with -funsigned-char on all targets
// Note: the L4RE kernel builds with -funsigned-char on all targets, but
// we only have a target for userspace apps so it follows the architectures.
if #[cfg(all(
not(windows),
not(target_vendor = "apple"),
Expand All @@ -113,7 +114,6 @@ mod c_char_definition {
target_arch = "riscv32",
target_arch = "s390x",
target_arch = "xtensa",
target_os = "l4re",
)
))] {
pub type c_char = u8;
Expand Down

0 comments on commit cd34d19

Please sign in to comment.