Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain to 2024-08-05 #3416

Merged

Conversation

tautschnig
Copy link
Member

@tautschnig tautschnig commented Aug 5, 2024

The toolchain upgrade to 2024-08-04 includes several bugfixes to dead-code analysis in rustc, explaining why we the recent PRs as listed above weren't flagged before for introducing dead code.

Resolves: #3411

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

* Remove `gen_function_local_variable` and `initializer_fn_name`, the
  last uses of both of which were removed in model-checking#3305.
* Remove `arg_count`, which was introduced in model-checking#3363, but not actually
  used.
* Remove `insert_bb`, which was introduced in model-checking#3382, but not actually
  used.

The toolchain upgrade to 2024-08-04 includes several bugfixes to
dead-code analysis in rustc, explaining why we the recent PRs as listed
above weren't flagged before for introducing dead code.

Resolves: model-checking#3411
@tautschnig tautschnig requested a review from a team as a code owner August 5, 2024 08:33
@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Aug 5, 2024
@artemagvanian
Copy link
Contributor

Is it possible to temporarily mark insert_bb and arg_count as allow_unused instead of removing them altogether? They were added in separate PRs to make it easier to review, and I plan to use them in the next PR I am authoring.

@tautschnig
Copy link
Member Author

Is it possible to temporarily mark insert_bb and arg_count as allow_unused instead of removing them altogether? They were added in separate PRs to make it easier to review, and I plan to use them in the next PR I am authoring.

Done.

@tautschnig tautschnig added this pull request to the merge queue Aug 5, 2024
Merged via the queue into model-checking:main with commit 520cb3e Aug 5, 2024
26 of 27 checks passed
@tautschnig tautschnig deleted the toolchain-2024-08-05-manual branch August 5, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolchain upgrade to nightly-2024-08-04 failed
3 participants