Add fixme tests for function contracts #3371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
changed the title
zhassan-aws
reviewed
Aug 12, 2024
| fn check_set_val() { | ||
| let mut obj = CharASCII::any(); | ||
| let original = obj.0; | ||
| let new_val = kani::any_where(|new| *new != original); |
There was a problem hiding this comment.
No.. I used to have an assertion after that relied on it.
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
zhassan-aws
reviewed
Aug 13, 2024
|
|
||
| impl kani::Arbitrary for CharASCII { | ||
| fn any() -> CharASCII { | ||
| let val = kani::any_where(|inner: &u8| *inner <= 128); |
There was a problem hiding this comment.
This now needs to be updated to a strict less than (*inner < 128).
| /// receivers. | ||
| impl CharASCII { | ||
| #[kani::modifies(&self.0)] | ||
| #[kani::requires(new_val <= 128)] |
There was a problem hiding this comment.
Same here (and other occurrences below).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding a few fix-me tests that I bumped into while working on #3363. Most of them will be fixed by #3363, except the one related to #3370.
The original PR is already quite large, so I decided to just push all of these as fixme tests for now. This is now ready for review!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.