Remove empty box creation from contracts impl #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be an issue in CBMC contracts implementation that it assumes that `free` must have a body. However, slicing can remove `free` body if the harness does not allocate anything. We used to create an empty Box before to force `free` to be in scope. Instead, just invoke `free(NULL)` which is a no-op.
jaisnan
approved these changes
Jun 6, 2024
|
Relevant issue filed on the CBMC side: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue in CBMC contracts implementation that it assumes that
freemust have a body. However, slicing can removefreebody if the harness does not allocate anything.We used to create an empty Box before to force
freeto be in scope. Instead, just invokefree(NULL)which is a no-op.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.