Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CBMC version to 5.88.0 #2614

Merged
merged 3 commits into from
Jul 22, 2023
Merged

Conversation

qinheping
Copy link
Contributor

Description of changes:

Upgrade to latest CBMC version.

Resolved issues:

Resolves #ISSUE-NUMBER

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested?

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@qinheping qinheping requested a review from a team as a code owner July 20, 2023 22:25
@qinheping qinheping changed the title Upgrade CBMC version to 5.88.0 Bump CBMC version to 5.88.0 Jul 20, 2023
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhassan-aws
Copy link
Contributor

Please update the version on the following line as well:

https://github.com/model-checking/kani/blob/main/scripts/kani-regression.sh#L22C22-L22C22

Copy link
Contributor

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@feliperodri feliperodri mentioned this pull request Jul 21, 2023
4 tasks
@qinheping qinheping enabled auto-merge (squash) July 21, 2023 18:00
@qinheping qinheping merged commit a27905f into model-checking:main Jul 22, 2023
@zhassan-aws
Copy link
Contributor

Just realized that we should've labeled this PR with Z-BenchCI so that benchcomp is run :(

@qinheping
Copy link
Contributor Author

Just realized that we should've labeled this PR with Z-BenchCI so that benchcomp is run :(

Yes. However, it seems that the benchcomp is running for this PR https://github.com/model-checking/kani/actions/runs/5627831808/job/15250966176. Let's wait for the result to see if we want to revert this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants