Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cargo build-dev produce a proper exit code #2398

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

tautschnig
Copy link
Member

Description of changes:

Build failures of Kani-related components did not result in a non-zero exit code.

Resolved issues:

n/a

Related RFC:

n/a

Call-outs:

n/a

Testing:

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • n/a Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@tautschnig tautschnig requested a review from a team as a code owner April 20, 2023 12:50
Copy link
Contributor

@adpaco-aws adpaco-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tautschnig ! Just a couple of minor comments.

If I'm not mistaken, this will prevent this error that @karkhaz had a while ago:

error: extern location for std does not exist: /home/runner/work/kani/kani/target/kani/lib/libstd.rlib

tools/build-kani/src/sysroot.rs Outdated Show resolved Hide resolved
tools/build-kani/src/sysroot.rs Outdated Show resolved Hide resolved
@tautschnig
Copy link
Member Author

Thanks, @tautschnig ! Just a couple of minor comments.

If I'm not mistaken, this will prevent this error that @karkhaz had a while ago:

error: extern location for std does not exist: /home/runner/work/kani/kani/target/kani/lib/libstd.rlib

Indeed, I had very similar issues, and by now I've had them more than once...

Build failures of Kani-related components did not result in a non-zero
exit code.
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

tools/build-kani/src/main.rs Show resolved Hide resolved
@tautschnig tautschnig merged commit e1bc7bf into model-checking:main Apr 21, 2023
@tautschnig tautschnig deleted the fail-build branch April 21, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants