-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Concrete Playback Unit tests to run with --cfg kani
#2353
Enable Concrete Playback Unit tests to run with --cfg kani
#2353
Conversation
…x-concrete-playback-cfg-kani
…x-concrete-playback-cfg-kani
tests/script-based-pre/concrete_playback_test/concrete_playback_test.sh
Outdated
Show resolved
Hide resolved
tests/script-based-pre/concrete_playback_test/concrete_playback_test.sh
Outdated
Show resolved
Hide resolved
tests/script-based-pre/concrete_playback_test/concrete_playback_test.sh
Outdated
Show resolved
Hide resolved
tests/script-based-pre/concrete_playback_test/concrete_playback_test.sh
Outdated
Show resolved
Hide resolved
tests/script-based-pre/concrete_playback_test/concrete_playback_test.sh
Outdated
Show resolved
Hide resolved
tests/script-based-pre/playback_with_cfg_kani/sample_crate/src/main.rs
Outdated
Show resolved
Hide resolved
Thanks Jai for fixing this. I was also thinking that we could improve this logic by making the default the behaviour that is today activated by concrete playback. Instead of using I didn't want to suggest this before so this fix wouldn't get too big. But I think it would address @karkhaz important concern of cfg explosion. |
…/main.rs Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
* The Kani reference now includes an ["Attributes"](https://model-checking.github.io/kani/reference/attributes.html) section that describes each of the attributes available in Kani ([pull request](model-checking#2359) by @adpaco-aws) * Users' choice of SAT solver, specified by the `solver` attribute, is now propagated to the loop-contract synthesizer ([pull request](model-checking#2320) by @qinheping) * Unit tests generated by the concrete playback feature now compile correctly when using `RUSTFLAGS="--cfg=kani"` ([pull request](model-checking#2353) by @jaisnan) * The Rust toolchain is updated to 2023-02-18 ([pull request](model-checking#2384) by @tautschnig)
Description of changes:
Fixes #1610 by creating a
concrete_playback
feature inkani_macros
. Users can now call their unit tests with the command -RUSTFLAGS="--cfg=kani" cargo +nightly test
.Resolved issues:
Resolves #1610
Call-outs:
Still need to pass
+nightly
with the tests. Already recorded in #1609.Testing:
How is this change tested? Regression tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.