Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some clippy warnings #1429

Merged
merged 4 commits into from
Aug 2, 2022
Merged

Fix some clippy warnings #1429

merged 4 commits into from
Aug 2, 2022

Conversation

fzaiser
Copy link
Contributor

@fzaiser fzaiser commented Jul 29, 2022

Description of changes:

Fix some clippy warnings.

Testing:

  • How is this change tested? No tests needed (refactor)

  • Is this a refactor change? yes

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@fzaiser fzaiser requested a review from a team as a code owner July 29, 2022 21:59
@fzaiser fzaiser self-assigned this Jul 30, 2022
@YoshikiTakashima YoshikiTakashima mentioned this pull request Jul 30, 2022
Closed
2 tasks
danielsn
danielsn reviewed Aug 1, 2022
View reviewed changes
cprover_bindings/src/goto_program/expr.rs Outdated
} else {
false
target.is_empty()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change I don't love, because it messes with the parallel pattern in the else ifs .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I can revert that one.

danielsn
danielsn reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@danielsn danielsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than one change I'm unsure if its an improvement

@fzaiser fzaiser merged commit 43cb18c into model-checking:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsn danielsn danielsn approved these changes

Assignees

@fzaiser fzaiser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaiser @danielsn