Fixes PostGIS model registration #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anapaulagomes
approved these changes
Feb 27, 2020
| @@ -143,7 +143,7 @@ def get_type_mapping(): | |||
|
|
|||
| mapping = default_mapping.copy() | |||
| mapping[ContentType] = random_gen.gen_content_type | |||
| default_mapping.update(default_gis_mapping) | |||
| mapping.update(default_gis_mapping) | |||
There was a problem hiding this comment.
❤️ thanks for catching this!!!
berinhard
approved these changes
Feb 27, 2020
| @@ -143,7 +143,7 @@ def get_type_mapping(): | |||
|
|
|||
| mapping = default_mapping.copy() | |||
| mapping[ContentType] = random_gen.gen_content_type | |||
| default_mapping.update(default_gis_mapping) | |||
| mapping.update(default_gis_mapping) | |||
There was a problem hiding this comment.
❤️ thanks for catching this!!!
|
I'm merging this since 2/3 maintainers have approved it 👍 |
|
@anapaulagomes and @amureki what do you think about a new release adding this PR? |
|
@berinhard sure, why not? If possible, we should try to add a regression test for this case to not break it in the future again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of
generators.get_type_mapping()is being used when registering types inbaker.init_type_mapping, but the return value ofget_type_mappingis being set to the copied value of the mappings before postgis models have been added. This leads model baker to believe that the PostGis models are invalid, when in fact, they are valid.Given this model in
myapp/models.py...The code below errors when executed in the Django shell:
with the following error:
TypeError: <class 'django.contrib.gis.db.models.fields.PointField'> is not supported by baker.I've tested this change locally, and it works, but I'm not sure why this is not being picked up in the tests on TravisCI