Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #498 -- Reset GFK fields when content object is None #499

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

amureki
Copy link
Collaborator

@amureki amureki commented Aug 23, 2024

Describe the change
We don't want to set content_type and object_id fields to a random values in case where the content_object is None, but _fill_optional=True.

PR Checklist

  • Change is covered with tests
  • CHANGELOG.md is updated if needed

@amureki amureki added the bug Something isn't working label Aug 23, 2024
@amureki amureki self-assigned this Aug 23, 2024
@amureki amureki merged commit 8b60451 into main Aug 26, 2024
9 checks passed
@amureki amureki deleted the 498/gfks-with-optional-fields branch August 26, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant