Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 to travis #39

Closed
wants to merge 1 commit into from
Closed

Add flake8 to travis #39

wants to merge 1 commit into from

Conversation

anapaulagomes
Copy link
Contributor

@anapaulagomes anapaulagomes commented Nov 24, 2019

The library was already configured in our tox.ini but never added to our Travis CI.

@anapaulagomes anapaulagomes marked this pull request as ready for review November 24, 2019 21:25
@anapaulagomes
Copy link
Contributor Author

I wonder if we could use a matrix in our Travis, so our linters wouldn't run in every job. What do you think, @amureki @berinhard?

Copy link
Collaborator

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anapaulagomes good catch, Ana!

I agree, adding flake8 to every job is not rational. I won't be against adding it this way as a temporary solution if you feel like this might help us short term.

Long term we'd need to revise this. flake8 is listed in envlist of tox.ini and meant to run separately. But the way we run tox in Travis would not cover it.

I can try to dig into it tonight as well, if you don't mind.

@anapaulagomes
Copy link
Contributor Author

It would be great if you could do it, @amureki. Thanks!

@anapaulagomes
Copy link
Contributor Author

Closed in favor of #40.

@anapaulagomes anapaulagomes deleted the add-flake8-to-travis branch November 25, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants