Fix creation of model instances with related model fields #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#117 introduced an issue for cases where `id` values is provided as a default for foreign keys. This PR attempts to fix that issue by checking if generated value for FK field is an instance of this model - if not it uses `_id` as a field name (https://docs.djangoproject.com/en/3.1/ref/models/fields/#database-representation).
amureki
force-pushed
the
issues/136/fix_fk_regression
branch
from
480e51c
to
73ac0d3
Compare
amureki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#117 introduced an issue for two cases :
idvalue is provided as default for foreign keyNone, but we overwrite this default by some valueSee discussion in #136 that led to a current solution (first fix attempt was different, see 035281c).
This PR attempts to fix that issue by checking if the field has a default AND not overwritten in
self.rel_fields.I've added test cases, kindly suggested by @cb109 in #136.