Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove Django 1.11 notes #157

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Conversation

amureki
Copy link
Collaborator

@amureki amureki commented Mar 1, 2021

We dropped Django 1.11 support in 1.2.1:
https://github.com/model-bakers/model_bakery/blob/main/CHANGELOG.md#121

Documentation and requirements were still referencing this version.
It is time to drop it completely (this Django version is not being maintained since April 2020: https://www.djangoproject.com/download/#supported-versions).

We dropped Django 1.11 support in 1.2.1:
https://github.com/model-bakers/model_bakery/blob/main/CHANGELOG.md#121

Documentation and requirements were still referencing this version.
It is time to drop it completely (this Django version is not being maintained since April 2020: https://www.djangoproject.com/download/#supported-versions).
@amureki amureki self-assigned this Mar 1, 2021
@github-actions
Copy link

github-actions bot commented Mar 1, 2021

@amureki your pull request is missing a changelog!

@amureki
Copy link
Collaborator Author

amureki commented Mar 1, 2021

@berinhard @anapaulagomes what do you think about releasing the next version? We already have quite some unreleased changes there.

Also, as you see in this PR, we were still "supporting" Django 1.11. I wonder if the release completely dropping it (with this PR) should be treated as a major version? https://semver.org/

@amureki amureki requested a review from a team March 1, 2021 08:07
@amureki amureki requested a review from berinhard March 1, 2021 08:24
@amureki amureki assigned berinhard and unassigned amureki Mar 1, 2021
Copy link
Member

@berinhard berinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for being so careful with these details @amureki!

@berinhard berinhard merged commit 2043cdb into main Mar 1, 2021
@berinhard berinhard deleted the finalize_dropping_111_django branch March 1, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants