Add a unit test for utils.seq
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amureki your pull request is missing a changelog! |
added 2 commits
February 18, 2021 17:23
Previously, we only tested it within recipe tests.
|
@anapaulagomes may I ask you to check out this PR as well? #147 is based on this one, so I'd like to merge this first.. |
anapaulagomes
approved these changes
Feb 27, 2021
|
@anapaulagomes thank you very much, Ana! 🤗 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only tested it within recipe tests.
I decided to put a dedicated unit-test, which also directly covers
USE_TZsetting.