Modify setup.py
to not import the whole module for package data
#142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #141 I found out that we are importing the whole
model_bakery
lib just in order to obtain__version__
.And due to the change in imports, tox starts to fail.
I decided to move some bits around and put stuff in a separate
__about__.py
, which would be read bysetup.py
.This structure works quite fine in my other packages.
What do you think? I am happy to use a different approach, the only thing is important that we should not import lib for nothing. :)