[#65] Add _bulk_create parameter to make
#134
Conversation
|
@berinhard @anapaulagomes I am not sure the root cause of the GitHub Action failures or whether there is anything I can do to fix them. For what it's worth, the tests are passing on my local machine (even the PostgreSQL and Postgis tests). |
|
I'm looking into it @timjklein36. |
|
@anapaulagomes it seems to be an issue with Ubuntu's repositories: |
|
Yeah, I saw this @berinhard. I tried to fix it with a suggestion from the GA community but it didn't work (#135). I'll continue tomorrow. |
|
@timjklein36 could you, please, rebase your change? @anapaulagomes fixed the issue, so it should work now! |
- This enables the use of `bulk_create` for the models that are created with `_quantity` supplied. This could offer performance advantages when creating large quantities of data. - It works by instead "preparing" the models and supplying them to the `_base_manager.bulk_create`.
- This tests to make sure `_bulk_create` works with models that have custom Managers. - This adds an assertion that without `_bulk_create=True` there will be the number of queries to the DB equal to the value of `_quantity`.
timjklein36
force-pushed
the
tk/quantity_bulk_create
branch
from
3ee3668
to
db1a5da
Compare
There was a problem hiding this comment.
It looks good to me! My only note is about the use of _refresh_after_create.
Thank you for another valuable contribution, @timjklein36.
- This is not needed when using _bulk_create since prepare does not save the models directly
- Kwarg already has a default value and `None` is not needed as a valid value, so no need for the `Optional` type.
|
@anapaulagomes @berinhard @amureki Ready for your re-review at your earliest convenience. Thanks! |
bulk_createfor the models that arecreated with
_quantitysupplied. This could offer performanceadvantages when creating large quantities of data.
to the
_base_manager.bulk_create.Fixes #65