Fix compatibility with Django 3.1 and actually run test against it #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berinhard
requested changes
Oct 5, 2020
There was a problem hiding this comment.
Thanks for the catch @michael-k! Can you only update the changelog with your changes? Besides that, I'm a huge +1
Unrelated PS: nice nick! it remembered me one of my favorites books which is called The Life and Times of Michael K, from Coetzee
Done |
berinhard
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Thanks a lot @michael-k! I'll wait for an extra review from @anapaulagomes or @amureki and we can merge this in 👍
anapaulagomes
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django.contrib.postgres.fields.FloatRangeFieldhas been removed in Django 3.1, see https://docs.djangoproject.com/en/3.1/releases/3.1/#features-removed-in-3-1