Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for suffix in seq (fix #93) #111

Merged
merged 11 commits into from
Oct 6, 2020

Commits on Oct 2, 2020

  1. [model-bakers#93] Add support for suffix in seq

    - This adds a new `suffix` keyword arg to the `seq` function to allow
      the concatenation of a common suffix string onto a generated `seq`
      value.
    - This adds a section under "Sequences in recipes" to the documentation
      to provide example usage of the new keyword argument.
      - Additionally, an `email` field is added to the `Customer` example
        model in the README.md to go along with the new section in the
        documentation.
    - This also adds unit tests for the new keyword argument behavior.
    timjk-gp committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    da0c9ff View commit details
    Browse the repository at this point in the history
  2. [model-bakers#93] Change example email field to models.EmailField

    - This also adds that example field to the other `Customer`
      class examples throughout the docs.
    timjk-gp committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    56823ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0580b41 View commit details
    Browse the repository at this point in the history
  4. [model-bakers#93] Raise TypeError if suffix is not text and used with…

    … text sequence
    
    - Also, change the str test case to use Person.email field (to better match
      the example mock data).
    timjk-gp committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    ad4190b View commit details
    Browse the repository at this point in the history
  5. [model-bakers#93] Fix lint issue

    - Removes unused variable in test method
    timjk-gp committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    d83cbcd View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Configuration menu
    Copy the full SHA
    a591405 View commit details
    Browse the repository at this point in the history
  2. [93] (CR) Change type checks to isinstance, add unit test

    - Changes made based on code review suggestions
    timjk-gp committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    879e3e9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9e72b07 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    39c9ad7 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Configuration menu
    Copy the full SHA
    06128bf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c977842 View commit details
    Browse the repository at this point in the history