Wrong typehinting in Recipe init

[GitRon]

The typehinting in the init method of Recipe is wrong. It states that _model is supposed to be str - but it can be an instance of django model as well.

Expected behavior

from typing import Union
from django.db import models
class Recipe(object):
    def __init__(self, _model: Union[str, models.Model], **attrs) -> None:

Actual behavior

class Recipe(object):
    def __init__(self, _model: str, **attrs) -> None:

Reproduction Steps

PyCharm will always show an error if I pass a model class to the Recipe. That is quite annoying and misleading.

Versions

Python: 3.8
Django: 3.1.2
Model Bakery: 1.2.0

Thanks!

[palfrey]

I think this is fixed in #115 (which isn't released yet)

[GitRon]

I think this is fixed in #115 (which isn't released yet)

Would be awesome! Any idea when the release is going to happen?

[berinhard]

Hi @GitRon! I'll release a new version today =)

[GitRon]

@berinhard Did you? 😅

[berinhard]

Yep! I was waiting for PR #126 to be merged. 1.2.1 is now live on pypi:

https://pypi.org/project/model-bakery/1.2.1/

[GitRon]

Awesome! But my PyCharm is still complaining. I think

_model: Union[str, Type[ModelBase]]

should be

_model: Union[str, Type[Model]]

What do you think @berinhard ?

Best
Ronny

[GitRon]

@berinhard I create a PR to tackle the issue.

[berinhard]

Thanks @GitRon! I added a comment in the PR

[GitRon]

@berinhard Awesome! I pushed a change on the changelog. Hope the pipeline will succeed 😅

[GitRon]

@berinhard Any chance that my fix will be pushed to pypi soon? ❤️

[berinhard]

@GitRon I don't think that I'll do that in the next days, sorry =S

If this is a deal breaker for you, I highly recommend you to install the project using the main branch in Github. I'm saying that because I'm planning to implement at least one of the following issues before a new release:

#25
#26
#65
#97

@GitRon you're very welcome to help me with any of these! @anapaulagomes @amureki and @timjklein36 too =)

[GitRon]

Alright, if you have a plan, I can live with that. You are the boss here 😉