Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Ability to wait for messages #194

Merged
merged 1 commit into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,15 @@ func main() {
// use MessagesAndPurge() method
server.MessagesAndPurge()

// In case with flaky test environment you can wait for the specified number
// of messages to arrive or until timeout is reached use WaitForMessages() method
server.WaitForMessages(42, 1 * time.Millisecond)

// In case with flaky test environment you can wait for the specified number
// of messages to arrive or until timeout is reached and purge it on server
// after use WaitForMessagesAndPurge() method
server.WaitForMessagesAndPurge(42, 1 * time.Millisecond)

// To stop the server use Stop() method. Please note, smtpmock uses graceful shutdown.
// It means that smtpmock will end all sessions after client responses or by session
// timeouts immediately.
Expand Down
8 changes: 8 additions & 0 deletions message.go
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,11 @@ func (messages *messages) purge() []Message {

return copiedMessages
}

// Clears the messages slice
func (messages *messages) clear() {
messages.Lock()
defer messages.Unlock()

messages.items = nil
}
10 changes: 10 additions & 0 deletions message_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -267,3 +267,13 @@ func TestMessagesPurge(t *testing.T) {
assert.Len(t, messages.copy(), 0)
})
}

func TestMessagesClear(t *testing.T) {
t.Run("clears messages from items slice", func(t *testing.T) {
message, messages := new(Message), new(messages)
messages.append(message)
messages.clear()

assert.Len(t, messages.copy(), 0)
})
}
36 changes: 36 additions & 0 deletions server.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,26 @@ func (server *Server) Messages() []Message {
return server.messages.copy()
}

// WaitForMessages waits for the specified number of messages to arrive or until timeout is reached.
// Returns the messages and an error if timeout occurs before receiving expected number of messages.
func (server *Server) WaitForMessages(count int, timeout time.Duration) ([]Message, error) {
return server.fetchMessages(count, timeout, false)
}

// Public interface to get access to server messages
// and at the same time removes them.
// Returns slice with copy of messages
func (server *Server) MessagesAndPurge() []Message {
return server.messages.purge()
}

// WaitForMessagesAndPurge waits for the specified number of messages to arrive or until timeout is reached.
// Returns the messages and an error if timeout occurs before receiving expected number of messages.
// At the same time removes the messages from the server.
func (server *Server) WaitForMessagesAndPurge(count int, timeout time.Duration) ([]Message, error) {
return server.fetchMessages(count, timeout, true)
}

// Thread-safe getter of server port.
// Returns server.portNumber
func (server *Server) PortNumber() int {
Expand All @@ -139,6 +152,29 @@ func (server *Server) PortNumber() int {
return server.portNumber
}

// fetchMessages fetches messages with timeout from the server with or without purging.
// Returns messages and an error if timeout occurs before receiving expected number of messages.
func (server *Server) fetchMessages(count int, timeout time.Duration, withPurge bool) ([]Message, error) {
deadline := time.Now().Add(timeout)
for {
messages := server.Messages()
messageCount := len(messages)

if messageCount >= count {
if withPurge {
server.messages.clear()
}
return messages, nil
}

if time.Now().After(deadline) {
return messages, fmt.Errorf("timeout waiting for %d messages, got %d", count, messageCount)
}

time.Sleep(1 * time.Millisecond)
}
}

// Thread-safe getter to check if server has been started.
// Returns server.started
func (server *Server) isStarted() bool {
Expand Down
83 changes: 80 additions & 3 deletions server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"net"
"strings"
"testing"
"time"

"github.com/stretchr/testify/assert"
)
Expand Down Expand Up @@ -163,10 +164,32 @@ func TestServerMessages(t *testing.T) {
assert.NotSame(t, server.messages.items, server.Messages())
server.messages.RUnlock()
})
}

t.Run("no messages after purge", func(t *testing.T) {
server := newServer(configuration)
message := new(Message)
func TestServerWaitForMessages(t *testing.T) {
timeout := 1 * time.Millisecond

t.Run("when expected number of messages is received without timeout", func(t *testing.T) {
server, message := newServer(createConfiguration()), new(Message)
server.messages.append(message)
messages, err := server.WaitForMessages(len(server.messages.copy()), timeout)

assert.Equal(t, []Message{*message}, messages)
assert.NoError(t, err)
})

t.Run("when timeout occurs before receiving expected number of messages", func(t *testing.T) {
server := newServer(createConfiguration())
messages, err := server.WaitForMessages(1, timeout)

assert.EqualError(t, err, fmt.Sprintf("timeout waiting for %d messages, got %d", 1, 0))
assert.Empty(t, messages)
})
}

func TestServerMessagesAndPurge(t *testing.T) {
t.Run("returns empty messages after purge", func(t *testing.T) {
server, message := newServer(createConfiguration()), new(Message)
server.messages.append(message)

assert.NotEmpty(t, server.Messages())
Expand All @@ -175,6 +198,28 @@ func TestServerMessages(t *testing.T) {
})
}

func TestServerWaitForMessagesAndPurge(t *testing.T) {
timeout := 1 * time.Millisecond

t.Run("when expected number of messages is received without timeout", func(t *testing.T) {
server, message := newServer(createConfiguration()), new(Message)
server.messages.append(message)
messages, err := server.WaitForMessagesAndPurge(len(server.messages.copy()), timeout)

assert.Equal(t, []Message{*message}, messages)
assert.NoError(t, err)
assert.Empty(t, server.Messages())
})

t.Run("when timeout occurs before receiving expected number of messages", func(t *testing.T) {
server := newServer(createConfiguration())
messages, err := server.WaitForMessagesAndPurge(1, timeout)

assert.EqualError(t, err, fmt.Sprintf("timeout waiting for %d messages, got %d", 1, 0))
assert.Empty(t, messages)
})
}

func TestServerPortNumber(t *testing.T) {
t.Run("returns server port number", func(t *testing.T) {
portNumber := 2525
Expand All @@ -184,6 +229,38 @@ func TestServerPortNumber(t *testing.T) {
})
}

func TestServerFetchMessages(t *testing.T) {
timeout := 1 * time.Millisecond

t.Run("when expected number of messages is received without timeout", func(t *testing.T) {
server, message := newServer(createConfiguration()), new(Message)
server.messages.append(message)
messages, err := server.fetchMessages(len(server.messages.copy()), timeout, false)

assert.Equal(t, []Message{*message}, messages)
assert.NoError(t, err)
assert.NotEmpty(t, server.Messages())
})

t.Run("when expected number of messages is received with purging", func(t *testing.T) {
server, message := newServer(createConfiguration()), new(Message)
server.messages.append(message)
messages, err := server.fetchMessages(len(server.messages.copy()), timeout, true)

assert.Equal(t, []Message{*message}, messages)
assert.NoError(t, err)
assert.Empty(t, server.Messages())
})

t.Run("when timeout occurs before receiving expected number of messages", func(t *testing.T) {
server := newServer(createConfiguration())
messages, err := server.fetchMessages(1, timeout, false)

assert.EqualError(t, err, fmt.Sprintf("timeout waiting for %d messages, got %d", 1, 0))
assert.Empty(t, messages)
})
}

func TestServerIsStarted(t *testing.T) {
t.Run("returns current server started-flag status", func(t *testing.T) {
server := &Server{started: true}
Expand Down