Skip to content
This repository has been archived by the owner on Oct 5, 2021. It is now read-only.

Angular support #73

Merged
merged 7 commits into from
Nov 25, 2018
Merged

Angular support #73

merged 7 commits into from
Nov 25, 2018

Conversation

urish
Copy link
Collaborator

@urish urish commented Jun 28, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jun 28, 2018

Coverage Status

Coverage increased (+0.2%) to 89.181% when pulling 4d0e522 on angular into d487bb7 on master.

@urish urish force-pushed the angular branch 4 times, most recently from b5721cf to 062623c Compare June 29, 2018 00:16
@urish urish changed the title Angular support [WIP] Angular support Jun 29, 2018
@FallenRiteMonk
Copy link

Whats the state of this PR?

@urish
Copy link
Collaborator Author

urish commented Sep 21, 2018

It was pretty functional, though it had some issue when I used it for an Angular project created with yarn.

If you are interested, I can write for you instructions how to test it in your project (before it's published to NPM), so you can share your feedback as well

@FallenRiteMonk
Copy link

@urish that would be great! Thanks

@tw3
Copy link

tw3 commented Oct 8, 2018

It was pretty functional, though it had some issue when I used it for an Angular project created with yarn.

If you are interested, I can write for you instructions how to test it in your project (before it's published to NPM), so you can share your feedback as well

Hey @urish I would definitely be interested in learning how to use this tool for an Angular 5 codebase, any tips?

urish added 2 commits October 10, 2018 01:01
publish to npm to make beta testing easier for users
@urish
Copy link
Collaborator Author

urish commented Oct 9, 2018

@tw3 @FallenRiteMonk I published the beta version to npm, so testing should now be pretty much straight forward:

https://medium.com/@urish/angular-schematics-and-the-future-of-typewiz-c266a5442c82

@FallenRiteMonk
Copy link

@urish Just tried it on a small project of mine and got following error:

ERROR in : TypeError: Cannot read property 'text' of undefined

Further in the error stack trace I found multiple lines similar to this one:

Error: <PATH_TO_PROJECT>/apps/fortysix/src/app/components/features/features.component.ts is missing from the TypeScript compilation.

This is in a Nx workspace. Do you want me to give you more info's here, or should I open a new issue?

@urish
Copy link
Collaborator Author

urish commented Oct 10, 2018

@FallenRiteMonk yes, a new issue please. Can you please check if commenting out some of the code in features.component.ts fixes this TypeError?

@FallenRiteMonk FallenRiteMonk mentioned this pull request Oct 10, 2018
@urish urish merged commit 90d2831 into master Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants