Added conditional map support for mochijson2:encode/2 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etrepum
requested changes
Dec 18, 2016
| @@ -149,6 +149,43 @@ parse_decoder_options([{format, Format} | Rest], State) | |||
| when Format =:= struct orelse Format =:= eep18 orelse Format =:= proplist -> | |||
| parse_decoder_options(Rest, State#decoder{object_hook=Format}). | |||
|
|
|||
|
|
|||
| -ifdef(map_available). | |||
There was a problem hiding this comment.
It would be ideal to put this ifdef in the existing json_encode/2 function rather than having entirely separate versions of this function.
There was a problem hiding this comment.
@etrepum I thought you can't use macros in function head(s), so this was the solution I come up with, albeit not the prettiest one.
I tried the following:
-ifdef(map_avaliable).
json_encode(M, State) when is_map(M) ->
json_encode_map(M, State);
-endif.
json_encode(...) ->
...This is giving out to me when compiling on 18.3.
etrepum
added a commit
that referenced
this pull request
Dec 19, 2016
etrepum
added a commit
that referenced
this pull request
Dec 19, 2016
etrepum
added a commit
that referenced
this pull request
Dec 19, 2016
|
This is now available in the tagged v2.16.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map_availableadded to allow conditional support for maps