Fix otp19 deprecation #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since OTP 19 crypto:rand_bytes/1 has been deprecated in favour of crypto:strong_rand_bytes/1.
|
In order to remain compatible with older versions of Erlang this will need to be done conditionally with macros. |
umbec
force-pushed
the
fix_otp19_deprecation
branch
from
0f3775a to
8ddf8e7
Compare
|
More than reasonable! I added the macros but the test still fails in some cases, i'll give it a look tomorrow. |
umbec
force-pushed
the
fix_otp19_deprecation
branch
2 times, most recently
from
90ce7d8 to
02cd4cb
Compare
Since OTP 19 random has been deprecated in favour of rand.
umbec
force-pushed
the
fix_otp19_deprecation
branch
from
02cd4cb to
05dd6cd
Compare
|
Did it. |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OTP 19 random has been deprecated in favour of rand.
Since OTP 19 crypto:rand_bytes/1 has been deprecated in favour of crypto:strong_rand_bytes/1.
See otp_src_19.0.readme.