-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: github actions workflow improvements #5177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voxpelli
changed the title
ci: GitHub Actions workflow improvements
ci: github actions workflow improvements
Jul 15, 2024
voxpelli
force-pushed
the
workflow-improvements
branch
from
July 15, 2024 23:38
19ae145
to
e769953
Compare
This was referenced Jul 16, 2024
7 tasks
JoshuaKGoldberg
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 This is fantastic, thanks for the cleanup!
Nothing blocking from me. Just a couple of questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The major benefit is that the workflows are lot DRY:er now – main definition is only 40 lines of code since all the repetitive boilerplate is ripped out into a reusable part:
mocha/.github/workflows/mocha.yml
Lines 16 to 56 in 19ae145
This also ensures that the caching, installation etc will behave consistently in all the places and makes it easy to evolve it in a consistent manor.