doc: fix to show sponsors in narrow view #4793
Conversation
|
For my taste these logos are way too large. And the one of OpenJS Foundation belongs into the gray part, where the netlify logo shows up. |
|
Could you show a screenshot? |
|
I mean the current docs, even before this PR. Those logos are larger than our own Mocha logo. |
outsideris
force-pushed
the
fix-sponsors-log
branch
from
ac9c07c to
505fe11
Compare
|
I moved all sponsorship logos into the footer because I agreed they are too big.
under 400px width:
|
|
OpenJS Foundation is not a sponsor, but one of Mocha's owners. That's why I proposed to move its logo to the footer where OpenJS Foundation is mentioned several times. Imo the remaining true sponsors don't belong into the footer. I don't really like it, but it's upto you. |
|
Yes, I also don't like sponsors images bottom. It is a design issue. I will try another approach. |
|
How about we remove matomo and wallaby logos on our homepage? |
|
There are sponsor logos missing, at least the one of Saucelabs. There is a pending issue about that. |
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
outsideris
force-pushed
the
fix-sponsors-log
branch
from
505fe11 to
bddc02e
Compare
|
I fixed them. wide width:
narrow width: |
| alt="OpenJS Foundation Logo" | ||
| /> | ||
| <a href="https://wallabyjs.com" rel="external noopener" title="Mocha is sponsored by Wallaby" id="wallaby-logo"> | ||
| <img src="https://wallabyjs.com/assets/img/logoWithText.svg" loading="lazy" width="140" alt="Wallaby logo"> |
There was a problem hiding this comment.
Some logos are loaded out of the images folder, some by external links.
What's the difference? Performance?
There was a problem hiding this comment.
I think there is no reason.
Whether we manage all assets on our side or not is only difference. Performance won't make much difference on mocha site.
* doc: move sponsorship logos into footer * doc: move sponsorship logos into bottom of content Signed-off-by: Outsider <outsideris@gmail.com>
In the narrow width screen, our sponsor logos disapear except the wallaby logo.
Now, all sponsor logos are displayed.
Under 320px width, logo size is not good, but it's fine over 320px width.