Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match supporter's properties with supporter.js #4569

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

outsideris
Copy link
Contributor

Currently, mochajs.org doesn't show any sponsors or backers.

I'm not sure when this problem occurred.
This commit introduced SPONSOR_TIER and BACKER_TIER constants and then this commit use these constants for supporters's child properties name.

So, we used supporters.sponsors and supporters.backers previously but, now it changed to supporters.sponsor and supporters.backer. However we didn't change supporters.md.

Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris outsideris added the area: website involving mochajs.org, but not necessarily involving docs label Feb 7, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.129% when pulling ac70ac0 on outsideris:fix-supporters-section into 9f2dd41 on mochajs:master.

Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outsideris thanks for this speedy fix!

@juergba juergba merged commit 6dd12be into mochajs:master Feb 7, 2021
@outsideris
Copy link
Contributor Author

Preview build was fine, but production build was failed on Netlify. I will check it.

@juergba juergba added type: bug a defect, confirmed by a maintainer semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Feb 7, 2021
@juergba juergba added this to the next milestone Feb 7, 2021
@juergba juergba modified the milestones: next, v8.3.0 Feb 11, 2021
This was referenced Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: website involving mochajs.org, but not necessarily involving docs semver-patch implementation requires increase of "patch" version number; "bug fixes" type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants