Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3483: Squelch CI Growl-related spawn errors #3517

Merged
merged 2 commits into from
Oct 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
###
### .travis.yml
###

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem with a file header?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only a filename. I feel it is redundant.

# these are executed in order. each must pass for the next to be run
stages:
- smoke # this ensures a "user" install works properly
Expand All @@ -8,6 +12,10 @@ stages:
# defaults
language: node_js
node_js: '10'
addons:
apt:
packages:
- libnotify-bin
# `nvm install` happens before the cache is restored, which means
# we must install our own npm elsewhere (`~/npm`)
before_install: |
Expand Down
69 changes: 57 additions & 12 deletions appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,27 +1,72 @@
platform:
- x64
###
### appveyor.yml
###

## General configuration
version: '{build}'
skip_commits:
message: /\[ci\s+skip\]/

## Environment configuration
shallow_clone: true
clone_depth: 1
environment:
matrix:
- nodejs_version: '10'
- nodejs_version: '9'
- nodejs_version: '8'
- nodejs_version: '6'
matrix:
fast_finish: true
install:
## Manual Growl install
- ps: Add-AppveyorMessage "Installing Growl..."
- ps: $exePath = "$($env:USERPROFILE)\GrowlInstaller.exe"
- ps: (New-Object Net.WebClient).DownloadFile('http://www.growlforwindows.com/gfw/downloads/GrowlInstaller.exe', $exePath)
- ps: mkdir C:\GrowlInstaller | out-null
- ps: 7z x $exePath -oC:\GrowlInstaller | out-null
- ps: cmd /c start /wait msiexec /i C:\GrowlInstaller\Growl_v2.0.msi /quiet
- ps: $env:path = "C:\Program Files (x86)\Growl for Windows;$env:path"
## Node-related installs
- ps: Add-AppveyorMessage "Installing Node..."
- set PATH=%APPDATA%\npm;C:\MinGW\bin;%PATH%
- ps: Install-Product node $env:nodejs_version x64
- set CI=true
- set PATH=%APPDATA%\npm;c:\MinGW\bin;%PATH%
- ps: Add-AppveyorMessage "Installing npm..."
- npm install -g npm@^5
## Mocha-related package installs
- ps: Add-AppveyorMessage "Installing Mocha dependencies..."
- npm ci --ignore-scripts
matrix:
fast_finish: true
build: off
version: '{build}'
shallow_clone: true
clone_depth: 1

## Build configuration
platform:
- x64
build: script
before_build:
## Growl requires some time before it's ready to handle notifications
- ps: Start-Process -NoNewWindow Growl
- ps: Add-AppveyorMessage "Started Growl service..."
- ps: Start-Sleep -Milliseconds 2000
build_script:
## Placeholder command
- ps: Start-Sleep -Milliseconds 0
#- ps: Add-AppveyorMessage "Verify Growl responding..."
#- ps: growlnotify test

## Test configuration
before_test:
- set CI=true
test_script:
- ps: Add-AppveyorMessage "Displaying version information"
- node --version
- npm --version
- ps: Add-AppveyorMessage "Running tests..."
- npm start test.node
skip_commits:
message: /\[ci\s+skip\]/
- ps: Add-AppveyorMessage "Done"

## Notifications
notifications:
- provider: Email
on_build_success: false
on_build_failure: false
on_build_status_changed: false