-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unloading files feature from require cache #3388
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
47bff62
Added unloading files feature
738a06a
Fixed lint issue
616a881
Moved tests to node-only
03aca1c
Fixed linting
23a9437
Mini code tweak
689bb64
It seems that arrow functions are not allowed :thinking:
3751a20
Updated tests
d1902a2
JSDoc tweak
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
'use strict'; | ||
|
||
var Mocha = require('../../lib/mocha'); | ||
var Path = require('path'); | ||
|
||
describe('.unloadFile()', function() { | ||
it('should load and unload file to/from cache', function() { | ||
var mocha = new Mocha({}); | ||
var filePath = __filename; | ||
|
||
mocha.addFile(filePath); | ||
mocha.loadFiles(); | ||
|
||
expect(require.cache, 'to have property', require.resolve(filePath)); | ||
mocha.unloadFile(filePath); | ||
expect(require.cache, 'not to have property', require.resolve(filePath)); | ||
}); | ||
}); | ||
|
||
describe('.unloadFiles()', function() { | ||
it('should unload all test files from cache', function() { | ||
var mocha = new Mocha({}); | ||
var testFiles = [ | ||
__filename, | ||
Path.join(__dirname, 'fs.spec.js'), | ||
Path.join(__dirname, 'color.spec.js') | ||
]; | ||
|
||
testFiles.forEach(function(file) { | ||
mocha.addFile(file); | ||
}); | ||
|
||
mocha.loadFiles(); | ||
testFiles.forEach(function(file) { | ||
expect(require.cache, 'to have property', require.resolve(file)); | ||
}); | ||
|
||
mocha.unloadFiles(); | ||
testFiles.forEach(function(file) { | ||
expect(require.cache, 'not to have property', require.resolve(file)); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this test would be more meaningful if we added multiple files, then made the assertion they were all removed by looping through
mocha.files
.