Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further build improvements #3315

Merged
merged 3 commits into from
Apr 7, 2018
Merged

further build improvements #3315

merged 3 commits into from
Apr 7, 2018

Conversation

boneskull
Copy link
Contributor

  • cache npm itself
  • use npm ci
  • cache the npm cache
  • ignore scripts when installing unless necessary
  • cache node_modules for npm install-using smoke tests
  • prefer flags over env vars

- cache npm itself
- use `npm ci`
- cache the npm cache
- ignore scripts when installing unless necessary
- cache `node_modules` for `npm install`-using smoke tests
- prefer flags over env vars

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@boneskull boneskull added qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Apr 7, 2018
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Copy link
Contributor

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@boneskull boneskull merged commit 7544bd3 into master Apr 7, 2018
@boneskull boneskull deleted the precache branch April 7, 2018 15:17
@boneskull boneskull added this to the v5.1.0 milestone Apr 7, 2018
This was referenced Sep 22, 2018
sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
- cache npm itself
- use `npm ci`
- cache the npm cache
- ignore scripts when installing unless necessary
- cache `node_modules` for `npm install`-using smoke tests
- prefer flags over env vars

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants