Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): fix links to some PRs #3276

Merged
merged 1 commit into from
Mar 18, 2018
Merged

fix(changelog): fix links to some PRs #3276

merged 1 commit into from
Mar 18, 2018

Conversation

tagoro9
Copy link
Contributor

@tagoro9 tagoro9 commented Mar 9, 2018

Description of the Change

I was checking the changelog of the latest versions and realized that some PR links had the wrong URL. They were https://github.com/mochajs/mocha/pulls/:id and they should be .../pull/:id.

This PR fixes those broken links.

Replace /pulls/:id wtih /pull/:id
@jsf-clabot
Copy link

jsf-clabot commented Mar 9, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.077% when pulling 5b6a401 on relayrides:fix_changelog_urls into d76f490 on mochajs:master.

@outsideris
Copy link
Contributor

Good catch.

@outsideris outsideris added the area: documentation anything involving docs or mochajs.org label Mar 12, 2018
@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Mar 18, 2018
@boneskull boneskull added this to the next milestone Mar 18, 2018
@boneskull boneskull merged commit 27af2cf into mochajs:master Mar 18, 2018
@boneskull
Copy link
Contributor

Thanks!

@tagoro9 tagoro9 deleted the fix_changelog_urls branch March 19, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants