-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added issue, pull request templates. #2869
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<!-- | ||
Have you read Mocha's Code of Conduct? By filing an Issue, you are expected to comply with it, including treating everyone with respect: https://github.com/mochajs/mocha/blob/master/.github/CODE_OF_CONDUCT.md | ||
For more, check out the Mocha gitter space: https://gitter.im/mochajs/mocha | ||
--> | ||
|
||
### Prerequisites | ||
<!-- | ||
Place an `x` between the square brackets on the lines below for every satisified prerequisite. | ||
--> | ||
* [ ] Checked that your issue isn't already filed by cross referencing [issues with the `common mistake` label](https://github.com/mochajs/mocha/issues?utf8=%E2%9C%93&q=is%3Aissue%20label%3Acommon-mistake%20) | ||
* [ ] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in the user's code. | ||
* [ ] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, the user's usage of Mocha, or Mocha itself | ||
|
||
### Description | ||
<!-- | ||
[Description of the issue] | ||
--> | ||
|
||
### Steps to Reproduce | ||
|
||
<!-- | ||
Please add a series of steps to reproduce the problem. See https://stackoverflow.com/help/mcve for in depth information | ||
on how to create a mimimal, complete, and verifiable example. | ||
--> | ||
|
||
**Expected behavior:** [What you expect to happen] | ||
|
||
**Actual behavior:** [What actually happens] | ||
|
||
**Reproduces how often:** [What percentage of the time does it reproduce?] | ||
|
||
### Versions | ||
<!-- | ||
You can get this information from copy and pasting the output of `mocha --version` from the command line. Also, please include the OS and what version of the OS you're running. | ||
--> | ||
|
||
### Additional Information | ||
<!-- | ||
Any additional information, configuration or data that might be necessary to reproduce the issue. | ||
--> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
### Requirements | ||
|
||
* Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. | ||
* All new code requires tests to ensure against regressions | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add a period ( |
||
|
||
### Description of the Change | ||
|
||
<!-- | ||
|
||
We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
--> | ||
|
||
### Alternate Designs | ||
|
||
<!-- Explain what other alternates were considered and why the proposed version was selected --> | ||
|
||
### Why Should This Be In Core? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. inconsistent capitalization |
||
|
||
<!-- Explain why this functionality should be in mocha as opposed to a package --> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. capitalize Mocha There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "as opposed to its own package" |
||
|
||
### Benefits | ||
|
||
<!-- What benefits will be realized by the code change? --> | ||
|
||
### Possible Drawbacks | ||
|
||
<!-- What are the possible side-effects or negative impacts of the code change? --> | ||
|
||
### Applicable Issues | ||
|
||
<!-- Enter any applicable Issues here --> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lowercase "issues" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add something like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about instead of "gitter space" "Gitter chat room", since not everyone knows what Gitter is?