increase test coverage of mocha.js #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Munter
approved these changes
May 15, 2017
ScottFreeCode
suggested changes
May 17, 2017
There was a problem hiding this comment.
This looks good in general! Thanks!
There are a couple "true" vs "false" issues (comments by the specific lines) that need to be fixed.
(Any other comments, while worth looking into on our part if nothing else, shouldn't block this from going in. Including the following comment...)
We should double-check consistency of method chainability, seeing that many but not all of these are being tested for chainability.
test/mocha.spec.js
Outdated
| mocha.options.ignoreLeaks.should.equal(true); | ||
| }); | ||
|
|
||
| it('should set the ignoreLeaks option to true when param equals false', function () { |
There was a problem hiding this comment.
"true" here should read "false".
test/mocha.spec.js
Outdated
| var mocha = new Mocha(blankOpts); | ||
| mocha.ignoreLeaks(false).should.equal(mocha); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Do we want to also test the behavior of .ignoreLeaks() (no parameter) while we're at it?
test/mocha.spec.js
Outdated
| mocha.options.useInlineDiffs.should.equal(true); | ||
| }); | ||
|
|
||
| it('should set the useInlineDiffs option to true when param equals false', function () { |
There was a problem hiding this comment.
"true" vs. "false" again
seppevs
force-pushed
the
increase_test_coverage_of_mocha_js
branch
from
78854cf to
1b1377c
Compare
|
Changes done. |
ScottFreeCode
approved these changes
Jun 15, 2017
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
…f_mocha_js increase test coverage of mocha.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few tests & increases the test coverage of mocha.js