always halt execution when async skip() called; closes #2465 #2479

boneskull · 2016-09-14T23:26:52Z

also fixes lack of support for async skip() when allowUncaught option is used
adds some debuggability into this.skip() calls

- also fixes lack of support for async `skip()` when `allowUncaught` option is used - adds some debuggability into `this.skip()` calls

…roperty-currentretry * upstream/master: helpful error when necessary suite callback omitted; closes mochajs#1744 Fix an issue and add relevant tests when describe and xdescribe fail when not supplied with a callback (issue mochajs#1744). rename more fixtures; closes mochajs#2383 Report non-match to STDERR and exit if no files are matched (mochajs#2450) Exit process with correct error codes (mochajs#2445) fix test files not using .spec suffix fix test fixtures not using .fixture suffix always halt execution when async skip() called; closes mochajs#2465 (mochajs#2479) avoid test flake in "delay" test; closes mochajs#2469 (mochajs#2470) revert accidental change to bin paths disregard function names when testing under Node.js 6.5.0; closes mochajs#2467 (mochajs#2477) lints more files; add more files to lint check; closes mochajs#2457 adds *.orig to .gitignore Exclude the --inspect flag fix check-leaks to catch a leak whose name begins with 'd'

…-files-cache * upstream/master: attempt windows-friendly reproducible case for mochajs#2315 fix: fix uncaught TypeError if error occurs on next tick, closes mochajs#2315 (mochajs#2439) helpful error when necessary suite callback omitted; closes mochajs#1744 Fix an issue and add relevant tests when describe and xdescribe fail when not supplied with a callback (issue mochajs#1744). rename more fixtures; closes mochajs#2383 Report non-match to STDERR and exit if no files are matched (mochajs#2450) Exit process with correct error codes (mochajs#2445) fix test files not using .spec suffix fix test fixtures not using .fixture suffix always halt execution when async skip() called; closes mochajs#2465 (mochajs#2479) avoid test flake in "delay" test; closes mochajs#2469 (mochajs#2470) revert accidental change to bin paths disregard function names when testing under Node.js 6.5.0; closes mochajs#2467 (mochajs#2477) lints more files; add more files to lint check; closes mochajs#2457 adds *.orig to .gitignore Exclude the --inspect flag fix check-leaks to catch a leak whose name begins with 'd'

…ochajs#2479) - always halt execution when async skip() called; closes mochajs#2465 - also fixes lack of support for async `skip()` when `allowUncaught` option is used - adds some debuggability into `this.skip()` calls - avoid double-failure conditions when using this.skip() - fix bad Runner tests; lint & add test/runner.js to check

boneskull added 2 commits September 16, 2016 14:02

always halt execution when async skip() called; closes #2465

b0c73a4

- also fixes lack of support for async `skip()` when `allowUncaught` option is used - adds some debuggability into `this.skip()` calls

avoid double-failure conditions when using this.skip()

9ba60f6

boneskull force-pushed the issue/2465 branch from e61e2c7 to 9ba60f6 Compare September 16, 2016 21:02

fix bad Runner tests; lint & add test/runner.js to check

286aa89

boneskull merged commit 5e1cd44 into master Sep 16, 2016

boneskull deleted the issue/2465 branch September 16, 2016 23:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

always halt execution when async skip() called; closes #2465 #2479

always halt execution when async skip() called; closes #2465 #2479

boneskull commented Sep 14, 2016

always halt execution when async skip() called; closes #2465 #2479

always halt execution when async skip() called; closes #2465 #2479

Conversation

boneskull commented Sep 14, 2016