Allow relative path to custom reporter #2453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new Error('reporter "' + program.reporter + '" does not exist'); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This all appears to be unnecessary since 191b88c
|
@boneskull Please review. The nested try-catch approach was pretty gnarly, so I flattened it. |
| // Try to load reporters from process.cwd() | ||
| if (!_reporter) { | ||
| try { | ||
| _reporter = require(path.resolve(process.cwd(), reporter)); |
There was a problem hiding this comment.
Turns out process.cwd() is unnecessary as a first argument. I'll push a fix.
Closes mochajs#2434 Previously, mocha --reporter=./path/to/custom-reporter.js would fail. Also removes code from _mocha that has been unnecessary since 191b88c
| throw new Error('reporter "' + program.reporter + '" does not exist'); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This all appears to be unnecessary since 191b88c
boneskull
reviewed
Sep 17, 2016
| // Try to load reporters from process.cwd() | ||
| if (!_reporter) { | ||
| try { | ||
| _reporter = require(path.resolve(reporter)); |
There was a problem hiding this comment.
This is going to be a problem if we're running in a browser. Why did this need to move out of _mocha?
boneskull
added
the
status: waiting for author
|
@cletusw any progress on this? I am looking to use this feature. Need help with getting the PR through? |
|
@sul4bh Yeah, I'll be unable to work on this for the foreseeable future. Feel free to take it from here! |
boneskull
removed
the
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2434
Previously, mocha --reporter=./path/to/custom-reporter.js would fail.
Also removes code from _mocha that has been unnecessary since 191b88c