Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README's header section #2214

Merged
merged 1 commit into from
Apr 17, 2016
Merged

Update README's header section #2214

merged 1 commit into from
Apr 17, 2016

Conversation

dasilvacontin
Copy link
Contributor

@dasilvacontin dasilvacontin commented Apr 17, 2016

  • Use new logo
  • Centers logo
  • Gives it some margin

I couldn't use the .svg's we have in /assets/ for some reason, maybe because of the way it was exported. You can try it out for yourselves. /cc @boneskull

If we were to use an image, we need a @2x export (double size) for retina screens. Hmm, I can actually generate one of those myself. But I hope we can solve the issues our svg files have.

I'll squash (or use "squash & merge") as necessary once the PR is reviewed, just in case we want to easily revert a subset of the changes.

@boneskull
Copy link
Contributor

LGTM

@boneskull
Copy link
Contributor

@dasilvacontin What does "couldn't use" mean?

@dasilvacontin
Copy link
Contributor Author

@boneskull image would display as broken, and opening the svg's url would display the file's raw content (xml tags and such), instead of a render of the svg (like happens when you open one of our badge's svg url)

@boneskull
Copy link
Contributor

@dasilvacontin I'm not seeing an example of hosting an .svg on GitHub and referencing it. Everyone else seems to use a remote image. Probably a good idea. Just stick em on cloudup.com or something

@dasilvacontin
Copy link
Contributor Author

@boneskull I tried imgur but they don't support svg. I'll try cloudup.

Btw, the logo with the simple, flexible, fun got the last n cut off – I didn't notice before merging, my bad.

Improves the looks of the README's top/header section:

- Updates logo to use the new design, svg hosted on Clodup
- Center logo
- Gives logo some top/bottom margin
@dasilvacontin dasilvacontin merged commit c0f9be2 into master Apr 17, 2016
@dasilvacontin dasilvacontin deleted the looks-and-bells branch April 17, 2016 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants