Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate "file" property across suites and tests for "exports" inter… #1993

Merged
merged 1 commit into from
Dec 25, 2015

Conversation

segrey
Copy link
Contributor

@segrey segrey commented Dec 3, 2015

suite.file and test.file are used by IntelliJ Mocha integration for "Jump to Source" action

Review on Reviewable

@segrey
Copy link
Contributor Author

segrey commented Dec 6, 2015

Now IntelliJ mocha integration uses test.file for navigation to test definition. So "Jump to Source" action won't work for exports interface without this change. Could you please take a look at this PR? Thanks!

@danielstjules
Copy link
Contributor

Looks good, thanks!

danielstjules added a commit that referenced this pull request Dec 25, 2015
propagate "file" property across suites and tests for "exports" inter…
@danielstjules danielstjules merged commit 9d8c154 into mochajs:master Dec 25, 2015
@segrey
Copy link
Contributor Author

segrey commented Dec 28, 2015

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants