-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1766: stackfilter should not ignore node_modules #1767
Conversation
👍 from me. |
I'm on mobile so difficult to see--but if this ensures anything in Mocha's own |
2f458ab
to
2952eca
Compare
Weird. I don't remember merging this... Edit: haha nvm, thanks @jbnicolai |
@danielstjules I merged it, and amended the message to reference and close this issue. GH should be more transparant about this.. |
No worries, appreciate it! :) |
Is this released? Just spent lost numerous hours fighting what I thought were source map issues only to finally find that it was this root issue. |
Not yet, no. It will be in the next minor release. Sorry for the inconvenience. |
Thanks, I hacked around it locally for now. Completely understand the lag time between fix and release. |
Fix for #1766