Correct erroneous test #1047
Merged
Correct erroneous test #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the Runnable under test is not part of a Suite, its context is undefined. Prior to this commit, the error returned was a runtime-generated `ReferenceError`, not a Mocha-generated `Error`. Set the timeout via the `Runnable#timeout` method, and update the test to assert the correct behavior (not implementation details such as the message body of the generated error).
Merged
travisjeffery
added a commit
that referenced
this pull request
Nov 30, 2013
Correct erroneous test * jugglinmike/fix-timeout-test-2: Correct erroneous test Conflicts: test/runnable.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the Runnable under test is not part of a Suite, its context is
undefined. Prior to this commit, the error returned was a
runtime-generated
ReferenceError, not a Mocha-generatedError.Set the timeout via the
Runnable#timeoutmethod, and update the testto assert the correct behavior (not implementation details such as the
message body of the generated error).