Adding promise support to runnables (and thus tests). #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If a runnable returns a duck-typed promise, i.e. an object with a `then` method, it gets treated as an async test, with success if the promise is fulfilled and failure if it is rejected (with the rejection reason as the error). * Includes tests both of new functionality and some to show that introducing this doesn't break any old functionality.
|
how do you open a PR from someone else's branch? |
|
Do you mean my ability of doing so, or the motivation of doing so? The ability is pretty much from Github ACL, I believe, as this is an open source community. My motivation is that I am extensively using promise pattern in my coding, even to break the req-res pattern in express into promise pattern. Had there not been this PR, I would do it myself. But, as we all say "do not reinvent the wheel", I did the search first. I also want to appreciate the original author of this PR, |
|
👍 |
|
@truongsinh Discussion on this is in #329, please close this PR as to not confuse people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thenmethod, it gets treated as an async test, with success if the promise is fulfilled and failure if it is rejected (with the rejection reason as the error).