Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Repo: Remove husky for now #5124

Closed
5 tasks done
voxpelli opened this issue Mar 26, 2024 · 3 comments · Fixed by #5127
Closed
5 tasks done

🛠 Repo: Remove husky for now #5124

voxpelli opened this issue Mar 26, 2024 · 3 comments · Fixed by #5127
Assignees
Labels
area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one!

Comments

@voxpelli
Copy link
Member

Tooling Suggestion Checklist

Overview

As mentioned in #5042 (comment), we decided to remove husky for now. Might re-add later.

Additional Info

No response

@voxpelli voxpelli added status: accepting prs Mocha can use your help with this one! area: repository tooling concerning ease of contribution labels Mar 26, 2024
@voxpelli voxpelli self-assigned this Mar 26, 2024
voxpelli added a commit that referenced this issue Mar 26, 2024
voxpelli added a commit that referenced this issue Mar 26, 2024
@JoshuaKGoldberg
Copy link
Member

Err, remove or fix? My preference would be to use it to enforce formatting on Git commit, and remove any linting.

@JoshuaKGoldberg
Copy link
Member

Explaining why I'm not in favor of this: Husky makes it a lot harder (admittedly, not impossible) to make commits locally that aren't well-formatted.

Not every contributor uses a nicely set up editor like VS Code with format-on-save. They might be new to development, and/or using something like Nodepad++, and/or just running with odd settings. For those edge cases, it's inconvenient to have to be told by CI that your change has formatting issues.

So from my perspective, there's very little downside to setting up formatting as a Git commit hook locally (node_modules/ is already going to be large; Knip recognizes properly set up Husky situations). And the upside is we have a bit more consistent, reliable of a dev experience - especially for new folks.

Which brings up a question: why do you two want to remove it? Assuming we're sticking to formatting on commit hooks and not linting or other more intrusive and/or time-intensive tasks... why not?

@voxpelli
Copy link
Member Author

I use husky on all of my own projects so I’m totally up for keeping it. I can’t remember exact reason why we discussed dropping it

voxpelli added a commit that referenced this issue Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants