🛠️ Repo: Two-column lists in the docs should not be the default style for lists #3702
Labels
area: documentation
anything involving docs or mochajs.org
good first issue
new contributors should look here!
status: accepting prs
Mocha can use your help with this one!
Comments
boneskull
added
status: accepting prs
|
would like to take this one. had to reconfigure "wd" module with fresh install to get tests to pass. |
tild4-d33
added a commit
to tild4-d33/mocha
that referenced
this issue
Feb 3, 2019
|
@crossaaron the at any rate, changes here should not affect any browser tests; the only potential failure would be a linting error. |
JoshuaKGoldberg
changed the title
marjys
added a commit
to marjys/mocha
that referenced
this issue
Mar 3, 2024
- Adds the two-column class with the expected style for two-column unordered lists, making sure to keep the two-column style at Features and Table of Contents - Removes column style from ul element scope
3 tasks
|
Hi! I'm new to Open Source and was looking for a good first issue to start contributing. May I give it a try? (#3702) |
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
pushed a commit
that referenced
this issue
Jun 19, 2024
* style: closes #3702 - Adds the two-column class with the expected style for two-column unordered lists, making sure to keep the two-column style at Features and Table of Contents - Removes column style from ul element scope * refactor: add two-column class to the toc Use the class two-column instead of applying the style by using its id. * refactor: move styles that are overwritten within other classes Move margin-top and padding inside two-column as they are overwritten within single-column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This should not be the default list style:
Change the stylesheet to display a "normal" list unless we apply a specific class for two-column display. I think it's OK to use in some places, but not for all lists.
unless there's a way to specify the class in our markdown compiler (not sure), just use html for the ones we keep. features and table of contents are good to keep... not sure about the rest.
For implementors:
To see changes locally, run
npm start docsand open updocs/_dist/index.htmlwith your browser. You can also donpm start docs.watchto rebuild as you work (you'll still have to reload).The text was updated successfully, but these errors were encountered: